Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New "Bulky" computers, small bug fixes also related to computers, addition of altitude controller to the CIC #6783

Closed
wants to merge 33 commits into from

Conversation

LC4492
Copy link
Contributor

@LC4492 LC4492 commented Jul 23, 2024

About the pull request

Adds new "Bulky" Computers to the CIC with their own unique designs, replacing the older and the added later computers (APOLLO and ARES consoles). Finally, physically adds the Altitude Controller to the CIC (With its own icon), giving players the opportunity of changing the Ship's altitude. Does a lot of fixes to the altitude changing code and makes small changes to the tactical map's sprite to make it look better. See the changelog for the explanation on how altitude changing works.

Attaching this here for good measure:
#2760

The Altitude Control Console have been integrated and designed to have two main altitudes: The lowest the Almayer can go and the most optimal, with the highest altitude being a non-selectable and mainly detrimental altitude. Staying on low altitude gives you considerable boosts to OB cooldown and Dropship Transport flights, but also requires the Ship's engines themselves to cooldown, given that remaining in low altitude will cause overheat. When the Ship hits 100% of overheat, ARES will automatically set the Almayer to the non-selectable high orbit, of which will give a 50% detriment to both OB cooldown and Dropship Transport flights, with ARES returning the ship to "most optimal" when the overheat percentage reach 0% again. That process can be manually jumped by a supervising and experienced Navigator. When not used, will not impact the round at all, given the Almayer will always remain in the "Most optimal" altitude when untouched.

Explain why it's good for the game

I mean, I think the computers look good enough, the altitude controller being available to the players is neat, and that bugfixes usually don't hurt, so... do you have any explanation to why it could be bad?

Testing Photographs and Procedure

Screenshots & Videos

image

Changelog

🆑
fix: Changes which icon the "Intel Database Computer" uses to fix a long-lasting bug. Alternate crew monitor icon fixes.
imageadd: Added new "IBM series 10" computers based on the "sensor computer" props that already exist in the code. Adds new tech-tree icon. Makes the tactical-map look a little better.
maptweak: Tweaks the CIC a little to accommodate the new computers. Adds the Altitude Controller to the ship's CIC. Changes the position of the medical belts to inside the armory. Makes the new "independent brig's console" on CIC to share with the bubble's camera console.
balance: Low altitude reduces OB cooldown and dropship flight times, but can only be maintained until overheated. Overheating will automatically enter high orbit for a time penalizing the OB cooldowns and dropship flight times until cooled over to overridden. Hijack flight time is unaffected.
/:cl:

@LC4492 LC4492 requested a review from Nanu308 as a code owner July 23, 2024 04:21
@github-actions github-actions bot added Sprites Remove the soul from the game. Mapping did you remember to save in tgm format? Fix Fix one bug, make ten more Grammar and Formatting Fixes the codebase's tpyos and grammatical's errors labels Jul 23, 2024
@Drulikar Drulikar added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Jul 23, 2024
code/game/machinery/computer/camera_console.dm Outdated Show resolved Hide resolved
code/game/supplyshuttle.dm Show resolved Hide resolved
code/modules/cm_marines/altitude_control_console.dm Outdated Show resolved Hide resolved
code/modules/cm_marines/altitude_control_console.dm Outdated Show resolved Hide resolved
code/modules/cm_marines/altitude_control_console.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar marked this pull request as draft July 23, 2024 12:24
@github-actions github-actions bot added the UI deletes nanoui/html label Jul 24, 2024
@LC4492 LC4492 marked this pull request as ready for review July 24, 2024 21:30
@LC4492 LC4492 requested a review from Drulikar July 24, 2024 21:30
cm13-github added a commit that referenced this pull request Aug 1, 2024
@LC4492
Copy link
Contributor Author

LC4492 commented Aug 2, 2024

List of problems encountered:

  1. Ares' messages were being repeated to each and every crewmember, with the spamming of over 30+ exact messages occuring often (fixed)
  2. Dropship flight times are not properly tied to the ship's altitude, not working at all (Need to look further on why "GLOB.ship_alt" is not being enough to handle it)
  3. Same above applies to the Orbital Cannon
  4. Too much shaking from constant altitude changes were giving players motion-sickness (fixed)

Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will be committing below suggestions, but do look at them.

code/modules/shuttle/computers/dropship_computer.dm Outdated Show resolved Hide resolved
code/modules/shuttle/computers/dropship_computer.dm Outdated Show resolved Hide resolved
cm13-github added a commit that referenced this pull request Aug 2, 2024
@Drulikar
Copy link
Contributor

Drulikar commented Aug 2, 2024

Changelog has been amended for spelling and clarity.

@rythenx

This comment was marked as off-topic.

@BeagleGaming1
Copy link
Contributor

Feedback for PRs should be submitted to the Forum's PR Feedback.

Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just remove the altitude mechanic and UI and repurpose the computer made for it for something else. The altitude mechanic I am just no longer comfortable with nor see any avenue for its use.

@Drulikar Drulikar marked this pull request as draft August 3, 2024 00:54
@Drulikar Drulikar removed Testmerge Candidate we'll test this while you're asleep and the server has 10 players Needs Testing Need to test it on the guinea pigs (production server) labels Aug 3, 2024
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Aug 7, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Drulikar
Copy link
Contributor

Drulikar commented Oct 7, 2024

Feel free to open again or request a reopen if altitude computer mechanic is removed.

@Drulikar Drulikar closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Fix Fix one bug, make ten more Grammar and Formatting Fixes the codebase's tpyos and grammatical's errors Mapping did you remember to save in tgm format? Merge Conflict PR can't be merged because it touched too much code Sprites Remove the soul from the game. UI deletes nanoui/html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants